5.10.1 question

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

5.10.1 question

Biddiscombe, John A.

I have a user who did a clean build of 5.10.1 on OSX which fails due to isnan and std:: namespace.

 

the user has sent me a patch, I’d like to test this patch on all systems (i.e. on the dashboard) and then submit it for inclusion in 5.10.1.x as the user in question can only use ‘released’ versions in their own releases.

 

Is there a way for me to have the patch tested on the dashboard on all architectures? on an experimental 5.10.x branch?

 

thanks

 

JB

 

--

John Biddiscombe,                        email:biddisco @.at.@ cscs.ch

http://www.cscs.ch/

CSCS, Swiss National Supercomputing Centre  | Tel:  +41 (91) 610.82.07

Via Trevano 131, 6900 Lugano, Switzerland   | Fax:  +41 (91) 610.82.82

 


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: 5.10.1 question

David E DeMarle

Not at the moment. But we are planning to update the gerrit infrastructure and repo branch testing setup to allow exactly that in the near term timeframe (couple of weeks is my guess).

On Sep 20, 2013 10:06 AM, "Biddiscombe, John A." <[hidden email]> wrote:

I have a user who did a clean build of 5.10.1 on OSX which fails due to isnan and std:: namespace.

 

the user has sent me a patch, I’d like to test this patch on all systems (i.e. on the dashboard) and then submit it for inclusion in 5.10.1.x as the user in question can only use ‘released’ versions in their own releases.

 

Is there a way for me to have the patch tested on the dashboard on all architectures? on an experimental 5.10.x branch?

 

thanks

 

JB

 

--

John Biddiscombe,                        email:biddisco @.at.@ cscs.ch

http://www.cscs.ch/

CSCS, Swiss National Supercomputing Centre  | Tel:  <a href="tel:%2B41%20%2891%29%20610.82.07" value="+41916108207" target="_blank">+41 (91) 610.82.07

Via Trevano 131, 6900 Lugano, Switzerland   | Fax:  <a href="tel:%2B41%20%2891%29%20610.82.82" value="+41916108282" target="_blank">+41 (91) 610.82.82

 


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: 5.10.1 question

Berk Geveci-2
Yeah. The goal is to start supporting 2 major releases for a while. In this case, VTK 5.x and 6.x. We'll upgrade the infrastructure to accept contributions to both.

-berk


On Fri, Sep 20, 2013 at 10:19 AM, David E DeMarle <[hidden email]> wrote:

Not at the moment. But we are planning to update the gerrit infrastructure and repo branch testing setup to allow exactly that in the near term timeframe (couple of weeks is my guess).

On Sep 20, 2013 10:06 AM, "Biddiscombe, John A." <[hidden email]> wrote:

I have a user who did a clean build of 5.10.1 on OSX which fails due to isnan and std:: namespace.

 

the user has sent me a patch, I’d like to test this patch on all systems (i.e. on the dashboard) and then submit it for inclusion in 5.10.1.x as the user in question can only use ‘released’ versions in their own releases.

 

Is there a way for me to have the patch tested on the dashboard on all architectures? on an experimental 5.10.x branch?

 

thanks

 

JB

 

--

John Biddiscombe,                        email:biddisco @.at.@ cscs.ch

http://www.cscs.ch/

CSCS, Swiss National Supercomputing Centre  | Tel:  <a href="tel:%2B41%20%2891%29%20610.82.07" value="+41916108207" target="_blank">+41 (91) 610.82.07

Via Trevano 131, 6900 Lugano, Switzerland   | Fax:  <a href="tel:%2B41%20%2891%29%20610.82.82" value="+41916108282" target="_blank">+41 (91) 610.82.82

 


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers




_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: 5.10.1 question

Sean McBride
In reply to this post by Biddiscombe, John A.
On Fri, 20 Sep 2013 14:04:23 +0000, Biddiscombe, John A. said:

>I have a user who did a clean build of 5.10.1 on OSX which fails due to
>isnan and std:: namespace.

That rings a few bells.

>the user has sent me a patch,

That code is pretty fragile, you might consider merging from VTK 6 -> 5 instead of using the patch he gave you.

Cheers,

--
____________________________________________________________
Sean McBride, B. Eng                 [hidden email]
Rogue Research                        www.rogue-research.com
Mac Software Developer              Montréal, Québec, Canada


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: 5.10.1 question

David Gobbi
On Fri, Sep 20, 2013 at 10:20 AM, Sean McBride <[hidden email]> wrote:

> On Fri, 20 Sep 2013 14:04:23 +0000, Biddiscombe, John A. said:
>
>>I have a user who did a clean build of 5.10.1 on OSX which fails due to
>>isnan and std:: namespace.
>
> That rings a few bells.
>
>>the user has sent me a patch,
>
> That code is pretty fragile, you might consider merging from VTK 6 -> 5 instead of using the patch he gave you.

Yeah, getting those vtkMath inlined functions to work on all systems
for VTK 6 was a huge pain.  Once VTK 5 is in gerrit, I'd be willing to
backport the fixes to VTK 5.

 David
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers