Library names for new cmake modules

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Library names for new cmake modules

David Gobbi
Hi Ben,

The new module system changes the so library names.  Was this intentional?

On MacOS:

libvtkCommonCore-8.90.8.90.0.dylib
libvtkCommonCore-8.90.dylib -> libvtkCommonCore-8.90.1.dylib
libvtkCommonCore-8.90.1.dylib -> libvtkCommonCore-8.90.8.90.0.dylib

vs

libvtkCommonCore-8.2.1.dylib
libvtkCommonCore-8.2.dylib -> libvtkCommonCore-8.2.1.dylib

On Linux:

libvtkCommonCore-8.90.so.8.90.0
libvtkCommonCore-8.90.so -> libvtkCommonCore-8.90.so.1
libvtkCommonCore-8.90.so.1 -> libvtkCommonCore-8.90.so.8.90.0

vs

libvtkCommonCore-8.2.so.1
libvtkCommonCore-8.2.so -> libvtkCommonCore-8.2.so.1

On an unrelated note, CMAKE_BUILD_TYPE=RelWithDebInfo causes duplicated targets.

  David







_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: Library names for new cmake modules

VTK - Dev mailing list
On Wed, Jan 09, 2019 at 10:45:39 -0700, David Gobbi wrote:
> The new module system changes the so library names.  Was this intentional?

<snip>

Hmm, this is probably because SOVERSION is now set. Maybe we shouldn't
do that?

> On an unrelated note, CMAKE_BUILD_TYPE=RelWithDebInfo causes duplicated
> targets.

Ooh, I hadn't seen that. Will investigate. What duplicate targets are
you seeing.

--Ben
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: Library names for new cmake modules

David Gobbi
On Wed, Jan 9, 2019 at 11:27 AM Ben Boeckel <[hidden email]> wrote:

Hmm, this is probably because SOVERSION is now set. Maybe we shouldn't
do that?

Since the version number is part of the base name, SOVERSION is redundant.


> On an unrelated note, CMAKE_BUILD_TYPE=RelWithDebInfo causes duplicated
> targets.

Ooh, I hadn't seen that. Will investigate. What duplicate targets are
you seeing.

With RelWithDebInfo, I get these errors (might not actually be a dup target):

Common/Core/CMakeFiles/CommonCore.dir/build.make:2026: warning: overriding commands for target `lib/libvtkCommonCore-8.90.8.90.0.dylib'
Common/Core/CMakeFiles/CommonCore.dir/build.make:2024: warning: ignoring old commands for target `lib/libvtkCommonCore-8.90.8.90.0.dylib'
Common/Core/CMakeFiles/CommonCore.dir/build.make:2026: warning: overriding commands for target `lib/libvtkCommonCore-8.90.8.90.0.dylib'
Common/Core/CMakeFiles/CommonCore.dir/build.make:2024: warning: ignoring old commands for target `lib/libvtkCommonCore-8.90.8.90.0.dylib'
make[2]: *** No rule to make target `optimized', needed by `lib/libvtkCommonCore-8.90.8.90.0.dylib'.  Stop.

  David


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: Library names for new cmake modules

VTK - Dev mailing list
On Wed, Jan 09, 2019 at 11:36:41 -0700, David Gobbi wrote:
> On Wed, Jan 9, 2019 at 11:27 AM Ben Boeckel <[hidden email]> wrote:
> > Hmm, this is probably because SOVERSION is now set. Maybe we shouldn't
> > do that?
>
> Since the version number is part of the base name, SOVERSION is redundant.

Sorry, not `SOVERSION` (which turns into ELF's `SONAME`). Removing
`VERSION ${VTK_VERSION}` in CMakeLists.txt should do it here.

> > On an unrelated note, CMAKE_BUILD_TYPE=RelWithDebInfo causes duplicated
> > > targets.
> >
> > Ooh, I hadn't seen that. Will investigate. What duplicate targets are
> > you seeing.
> >
>
> With RelWithDebInfo, I get these errors (might not actually be a dup
> target):
>
> Common/Core/CMakeFiles/CommonCore.dir/build.make:2026: warning: overriding
> commands for target `lib/libvtkCommonCore-8.90.8.90.0.dylib'
> Common/Core/CMakeFiles/CommonCore.dir/build.make:2024: warning: ignoring
> old commands for target `lib/libvtkCommonCore-8.90.8.90.0.dylib'
> Common/Core/CMakeFiles/CommonCore.dir/build.make:2026: warning: overriding
> commands for target `lib/libvtkCommonCore-8.90.8.90.0.dylib'
> Common/Core/CMakeFiles/CommonCore.dir/build.make:2024: warning: ignoring
> old commands for target `lib/libvtkCommonCore-8.90.8.90.0.dylib'
> make[2]: *** No rule to make target `optimized', needed by
> `lib/libvtkCommonCore-8.90.8.90.0.dylib'.  Stop.

Odd. I suspect these go away with the `VERSION` argument as well. The
`optimized` points to something else going wrong with a find module.

--Ben
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers