Moving generated headers in VTK

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Moving generated headers in VTK

Ben Boeckel
Hi,

When using VTK from a build tree on Windows, command line lengths get
out of hand quickly when linking many modules due to the fact that each
module adds its own source and build directory to the list. These
headers always include the export Module.h header, but sometimes other
headers are generated there as well. I have this merge request:

    https://gitlab.kitware.com/vtk/vtk/merge_requests/3159

which changes VTK to have a single location for generated headers (and
some sources due to the way vtkEncodeString works). This helps the
number of include directories to go from 2n to n+1. Third party packages
are skipped for now and manually add their build directories to the
include path instead since they tend to write to
CMAKE_CURRENT_BINARY_DIR inside of the third party packages anyways.

Thoughts?

--Ben
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: Moving generated headers in VTK

Andras Lasso
Thank you, this is very useful. Since VTK modularization, we have to build projects that use VTK and ITK in directories that only a few characters long (something like C:\D\Abc would work, but in C:\Dev\Abc\Def the project would fail to build).

Andras

-----Original Message-----
From: vtk-developers [mailto:[hidden email]] On Behalf Of Ben Boeckel
Sent: Thursday, August 17, 2017 8:59 AM
To: [hidden email]
Subject: [vtk-developers] Moving generated headers in VTK

Hi,

When using VTK from a build tree on Windows, command line lengths get out of hand quickly when linking many modules due to the fact that each module adds its own source and build directory to the list. These headers always include the export Module.h header, but sometimes other headers are generated there as well. I have this merge request:

    https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.kitware.com%2Fvtk%2Fvtk%2Fmerge_requests%2F3159&data=02%7C01%7Classo%40queensu.ca%7C464ba82ecda048fa4a4208d4e56fcc0b%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636385715700219688&sdata=0hEmLR9U391LTUUjp%2F47tYWpSaaJlDMsAaiGOpkk6bc%3D&reserved=0

which changes VTK to have a single location for generated headers (and some sources due to the way vtkEncodeString works). This helps the number of include directories to go from 2n to n+1. Third party packages are skipped for now and manually add their build directories to the include path instead since they tend to write to CMAKE_CURRENT_BINARY_DIR inside of the third party packages anyways.

Thoughts?

--Ben
_______________________________________________
Powered by https://na01.safelinks.protection.outlook.com/?url=www.kitware.com&data=02%7C01%7Classo%40queensu.ca%7C464ba82ecda048fa4a4208d4e56fcc0b%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636385715700219688&sdata=vPH0USoc7eEFJfzVNuhLR0s8yzNJacxMoZEkDqpRZ6Q%3D&reserved=0

Visit other Kitware open-source projects at https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.kitware.com%2Fopensource%2Fopensource.html&data=02%7C01%7Classo%40queensu.ca%7C464ba82ecda048fa4a4208d4e56fcc0b%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636385715700219688&sdata=MsNXtZy9VEoyy0HP3nzQij4xNGxqE5W5LMME2ixFH1w%3D&reserved=0

Search the list archives at: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmarkmail.org%2Fsearch%2F%3Fq%3Dvtk-developers&data=02%7C01%7Classo%40queensu.ca%7C464ba82ecda048fa4a4208d4e56fcc0b%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636385715700219688&sdata=Yt19ZJaZsQucbp7YINYLMflXIMJReSzb2g9qt%2Bej%2BTM%3D&reserved=0

Follow this link to subscribe/unsubscribe:
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpublic.kitware.com%2Fmailman%2Flistinfo%2Fvtk-developers&data=02%7C01%7Classo%40queensu.ca%7C464ba82ecda048fa4a4208d4e56fcc0b%7Cd61ecb3b38b142d582c4efb2838b925c%7C1%7C0%7C636385715700219688&sdata=xrvrob2lGDhRO7nXqJ0uplD5WHb6fXSZeFKoeuXZqdg%3D&reserved=0

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers