New cmake modules: TBB broken?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

New cmake modules: TBB broken?

David Gobbi
Hi Ben,

The new FindTBB.cmake is broken, specifically in this section starting at line 88:

set_target_propertes(TBB::${TARGET} PROPERTIES
      IMPORTED_LOCATION "${${PREFIX}_LIBRARY}"
      IMPORTED_LOCATION_DEBUG "${${PREFIX}_LIBRARY_DEBUG}"
      IMPORTED_LOCATION_RELEASE "${${PREFIX}_LIBRARY_RELEASE}")    target_include_directories(TBB::${TARGET} INTERFACE "${${PREFIX}_INCLUDE_DIR}")

There is an error for the "set_target_properties" typo, and these errors for "target_include_directories":

==
target_include_directories called with non-compilable target type
==
add_library cannot create imported target "TBB::" because another target
  with the same name already exists.
==

  - David



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: New cmake modules: TBB broken?

Clinton Stimpson
I had similar problems with FindX11.cmake.

I built VTK, then tried to use it in my application where I already have a find_package(X11), and it gave me tons of errors :
add_library cannot create imported target "X11::...." because another target with the same name already exists.

Clint

----- On Jan 8, 2019, at 10:00 AM, David Gobbi <[hidden email]> wrote:
Hi Ben,

The new FindTBB.cmake is broken, specifically in this section starting at line 88:
set_target_propertes(TBB::${TARGET} PROPERTIES
      IMPORTED_LOCATION "${${PREFIX}_LIBRARY}"
      IMPORTED_LOCATION_DEBUG "${${PREFIX}_LIBRARY_DEBUG}"
      IMPORTED_LOCATION_RELEASE "${${PREFIX}_LIBRARY_RELEASE}")    target_include_directories(TBB::${TARGET} INTERFACE "${${PREFIX}_INCLUDE_DIR}")

There is an error for the "set_target_properties" typo, and these errors for "target_include_directories":

==
target_include_directories called with non-compilable target type
==
add_library cannot create imported target "TBB::" because another target
  with the same name already exists.
==

  - David



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: New cmake modules: TBB broken?

VTK - Dev mailing list
In reply to this post by David Gobbi
On Tue, Jan 08, 2019 at 10:00:32 -0700, David Gobbi wrote:

> The new FindTBB.cmake is broken, specifically in this section starting at
> line 88:
>
> set_target_propertes(TBB::${TARGET} PROPERTIES
>       IMPORTED_LOCATION "${${PREFIX}_LIBRARY}"
>       IMPORTED_LOCATION_DEBUG "${${PREFIX}_LIBRARY_DEBUG}"
>       IMPORTED_LOCATION_RELEASE "${${PREFIX}_LIBRARY_RELEASE}")
> target_include_directories(TBB::${TARGET} INTERFACE
> "${${PREFIX}_INCLUDE_DIR}")
>
> There is an error for the "set_target_properties" typo, and these errors
> for "target_include_directories":

I'm working on a followup branch here:

    https://gitlab.kitware.com/vtk/vtk/merge_requests/5039

--Ben
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: New cmake modules: TBB broken?

VTK - Dev mailing list
In reply to this post by Clinton Stimpson
On Tue, Jan 08, 2019 at 10:34:09 -0700, [hidden email] wrote:
> I had similar problems with FindX11.cmake.
>
> I built VTK, then tried to use it in my application where I already have a find_package(X11), and it gave me tons of errors :
> add_library cannot create imported target "X11::...." because another target with the same name already exists.

Thanks for the report. Will guard the target creation with checks that
they don't already exist.

--Ben
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers