OpenVR compile error with new module system

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

OpenVR compile error with new module system

VTK - Dev mailing list
I found a typo in the OpenVR cmake:

diff --git a/Rendering/OpenVR/CMakeLists.txt b/Rendering/OpenVR/CMakeLists.txt
index a091afc3ce..810b062005 100644
--- a/Rendering/OpenVR/CMakeLists.txt
+++ b/Rendering/OpenVR/CMakeLists.txt
@@ -49,8 +49,8 @@ foreach (geometry_file IN LISTS geometry_files)
     SOURCE_OUTPUT source
     BINARY
     NUL_TERMINATE)
-  list(APPEND sources "${source}")
-  list(APPEND headers "${source}")
+  list(APPEND geometry_sources "${source}")
+  list(APPEND geometry_headers "${header}")
 endforeach ()

After this fix, I still get a related error:

ninja: error: 
'C:/akit/vtk/src/Rendering/OpenVR/vtkAvatarHead.h', needed by 'lib/vtk/hierarchy/VTK/vtkRenderingOpenVR-hierarchy.txt', missing and no known rule to make it

I'm not sure about this .txt file or what to do next?

Thanks,
Aron

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: OpenVR compile error with new module system

VTK - Dev mailing list
On Wed, Jan 09, 2019 at 16:11:54 -0500, Aron Helser wrote:

> I found a typo in the OpenVR cmake:
>
> diff --git a/Rendering/OpenVR/CMakeLists.txt
> b/Rendering/OpenVR/CMakeLists.txt
> index a091afc3ce..810b062005 100644
> --- a/Rendering/OpenVR/CMakeLists.txt
> +++ b/Rendering/OpenVR/CMakeLists.txt
> @@ -49,8 +49,8 @@ foreach (geometry_file IN LISTS geometry_files)
>      SOURCE_OUTPUT source
>      BINARY
>      NUL_TERMINATE)
> -  list(APPEND sources "${source}")
> -  list(APPEND headers "${source}")
> +  list(APPEND geometry_sources "${source}")
> +  list(APPEND geometry_headers "${header}")
>  endforeach ()

Oops, indeed.

> After this fix, I still get a related error:
>
> ninja: error:
> 'C:/akit/vtk/src/Rendering/OpenVR/vtkAvatarHead.h', needed by
> 'lib/vtk/hierarchy/VTK/vtkRenderingOpenVR-hierarchy.txt', missing and no
> known rule to make it
>
> I'm not sure about this .txt file or what to do next?

It means that a header named `vtkAvatarHead.h` is expected to be in the
build tree…it isn't. I suspect the `vtkAvatar*` listings in `classes`
should just be removed.

Please feel free to open an MR; I don't have OpenVR here at the moment
to test against.

--Ben
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: OpenVR compile error with new module system

VTK - Dev mailing list
Yes, the vtkAvatar* should not have been listed in 'classes' - I missed that.

The next issue I'm seeing:

   Creating library lib\vtkRenderingOpenVR-8.90d.lib and object lib\vtkRenderingOpenVR-8.90d.exp
vtkRenderingOpenVRObjectFactory.cxx.obj : error LNK2019: unresolved external symbol "public: static class vtkOpenGLAvatar * __cdecl vtkOpenGLAvatar::New(void)" (?New@vtkOpenGLAvatar@@SAPEAV1@XZ) referenced in function "class vtkObject * __cdecl vtkObjectFactoryCreatevtkOpenGLAvatar(void)" (?vtkObjectFactoryCreatevtkOpenGLAvatar@@YAPEAVvtkObject@@XZ)
bin\vtkRenderingOpenVR-8.90d.dll : fatal error LNK1120: 1 unresolved externals

I tried removing the quotes around ${vtk_object_factory_source} and header, but no dice.

MR here:

Thanks!

On Wed, Jan 9, 2019 at 4:47 PM Ben Boeckel <[hidden email]> wrote:
On Wed, Jan 09, 2019 at 16:11:54 -0500, Aron Helser wrote:
> I found a typo in the OpenVR cmake:
>
> diff --git a/Rendering/OpenVR/CMakeLists.txt
> b/Rendering/OpenVR/CMakeLists.txt
> index a091afc3ce..810b062005 100644
> --- a/Rendering/OpenVR/CMakeLists.txt
> +++ b/Rendering/OpenVR/CMakeLists.txt
> @@ -49,8 +49,8 @@ foreach (geometry_file IN LISTS geometry_files)
>      SOURCE_OUTPUT source
>      BINARY
>      NUL_TERMINATE)
> -  list(APPEND sources "${source}")
> -  list(APPEND headers "${source}")
> +  list(APPEND geometry_sources "${source}")
> +  list(APPEND geometry_headers "${header}")
>  endforeach ()

Oops, indeed.

> After this fix, I still get a related error:
>
> ninja: error:
> 'C:/akit/vtk/src/Rendering/OpenVR/vtkAvatarHead.h', needed by
> 'lib/vtk/hierarchy/VTK/vtkRenderingOpenVR-hierarchy.txt', missing and no
> known rule to make it
>
> I'm not sure about this .txt file or what to do next?

It means that a header named `vtkAvatarHead.h` is expected to be in the
build tree…it isn't. I suspect the `vtkAvatar*` listings in `classes`
should just be removed.

Please feel free to open an MR; I don't have OpenVR here at the moment
to test against.

--Ben

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://vtk.org/mailman/listinfo/vtk-developers