Quantcast

TemporalArrayOperator

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

TemporalArrayOperator

Ken Martin
Looks like a small typo

vtkTemporalArrayOperatorFilter.cxx: 267 in vtkTemporalArrayOperatorFilter::ProcessDataObject(vtkDataObject *, vtkDataObject *)()
261     //------------------------------------------------------------------------------
262     vtkDataObject* vtkTemporalArrayOperatorFilter::ProcessDataObject(
263       vtkDataObject* inputData0, vtkDataObject* inputData1)
264     {
265       vtkDataArray* inputArray0 = this->GetInputArrayToProcess(0, inputData0);
266       vtkDataArray* inputArray1 = this->GetInputArrayToProcess(0, inputData1);
>>>     CID 1372958:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "!inputArray1 || !inputArray1" does not accomplish anything because it evaluates to either of its identical operands, "!inputArray1".
267       if (!inputArray1 || !inputArray1)
268       {
269         vtkErrorMacro(<< "Unable to retrieve data arrays to process.");
270         return NULL;
271       }
272

--
Ken Martin PhD
Distinguished Engineer
Kitware Inc.
28 Corporate Drive
Clifton Park NY 12065

This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee.  Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message.  Thank you.

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TemporalArrayOperator

Joachim Pouderoux
Joachim

Joachim Pouderoux, PhD
Technical Expert - Scientific Computing Team
Kitware SAS

2017-03-25 14:28 GMT-04:00 Ken Martin <[hidden email]>:
Looks like a small typo

vtkTemporalArrayOperatorFilter.cxx: 267 in vtkTemporalArrayOperatorFilter::ProcessDataObject(vtkDataObject *, vtkDataObject *)()
261     //------------------------------------------------------------------------------
262     vtkDataObject* vtkTemporalArrayOperatorFilter::ProcessDataObject(
263       vtkDataObject* inputData0, vtkDataObject* inputData1)
264     {
265       vtkDataArray* inputArray0 = this->GetInputArrayToProcess(0, inputData0);
266       vtkDataArray* inputArray1 = this->GetInputArrayToProcess(0, inputData1);
>>>     CID 1372958:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "!inputArray1 || !inputArray1" does not accomplish anything because it evaluates to either of its identical operands, "!inputArray1".
267       if (!inputArray1 || !inputArray1)
268       {
269         vtkErrorMacro(<< "Unable to retrieve data arrays to process.");
270         return NULL;
271       }
272

--
Ken Martin PhD
Distinguished Engineer
Kitware Inc.
28 Corporate Drive
Clifton Park NY 12065

This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee.  Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message.  Thank you.

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers




_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TemporalArrayOperator

Sean McBride
In reply to this post by Ken Martin
On Sat, 25 Mar 2017 14:28:47 -0400, Ken Martin said:

>>>>     CID 1372958:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
>>>>     The expression "!inputArray1 || !inputArray1" does not accomplish
>anything because it evaluates to either of its identical operands,
>"!inputArray1".
>267       if (!inputArray1 || !inputArray1)

A good occasion to remind everyone to look at the nightly cppcheck dashboard :), where this has also been since Wednesday:

Filters/Hybrid/vtkTemporalArrayOperatorFilter.cxx:267: style: Same expression on both sides of '||'.

Sean


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers

Loading...