help wih 3 cppcheck warnings (vtkCell3D.cxx & vtkExtractSelectedIds.cxx)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

help wih 3 cppcheck warnings (vtkCell3D.cxx & vtkExtractSelectedIds.cxx)

Sean McBride
Hi all,

Anyone familiar with these 2 classes want to tackle these 3 cppcheck warnings?  They are not false positives, there is definite code smell:

oppositeExpression,Common/DataModel/vtkCell3D.cxx:122,style,Opposite expression on both sides of '||'.

identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:358,warning,Identical inner 'if' condition is always true.

identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:507,warning,Identical inner 'if' condition is always true.

Cheers,

Sean


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://public.kitware.com/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: help wih 3 cppcheck warnings (vtkCell3D.cxx & vtkExtractSelectedIds.cxx)

David E DeMarle
I'll fix the extract ids filter. 

On Wed, Sep 19, 2018, 10:04 PM Sean McBride <[hidden email]> wrote:
Hi all,

Anyone familiar with these 2 classes want to tackle these 3 cppcheck warnings?  They are not false positives, there is definite code smell:

oppositeExpression,Common/DataModel/vtkCell3D.cxx:122,style,Opposite expression on both sides of '||'.

identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:358,warning,Identical inner 'if' condition is always true.

identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:507,warning,Identical inner 'if' condition is always true.

Cheers,

Sean


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://public.kitware.com/mailman/listinfo/vtk-developers


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://public.kitware.com/mailman/listinfo/vtk-developers

Reply | Threaded
Open this post in threaded view
|

Re: help wih 3 cppcheck warnings (vtkCell3D.cxx & vtkExtractSelectedIds.cxx)

Ken Martin
In reply to this post by Sean McBride
I'll grab Cell3D

On Wed, Sep 19, 2018 at 9:55 PM, Sean McBride <[hidden email]> wrote:
Hi all,

Anyone familiar with these 2 classes want to tackle these 3 cppcheck warnings?  They are not false positives, there is definite code smell:

oppositeExpression,Common/DataModel/vtkCell3D.cxx:122,style,Opposite expression on both sides of '||'.

identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:358,warning,Identical inner 'if' condition is always true.

identicalInnerCondition,Filters/Extraction/vtkExtractSelectedIds.cxx:507,warning,Identical inner 'if' condition is always true.

Cheers,

Sean


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://public.kitware.com/mailman/listinfo/vtk-developers




--
Ken Martin PhD
Distinguished Engineer
Kitware Inc.
101 East Weaver Street
Carrboro, North Carolina
27510 USA

This communication, including all attachments, contains confidential and legally privileged information, and it is intended only for the use of the addressee.  Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you received this communication in error please notify us immediately and destroy the original message.  Thank you.

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
https://public.kitware.com/mailman/listinfo/vtk-developers